MessageSizeEvolution: Focus the chart on chosen entry methods - #169
Merged
Conversation
The reader was already told each message's entry method and threw it away. Keep the counts per entry method and sum only the chosen ones into the chart, so message sizes can be studied one entry method (or a few) at a time; a Select Entry Methods button opens the shared chooser with its visibility column, listing entry methods busiest first with their message counts. Everything starts visible, so the chart is unchanged until something is switched off. Events whose entry id is outside the sts table land in a catch-all slot that is always displayed, so filtering can never silently change the total. At the default 100x10 bins the per-entry-method array costs about 2 MB per 500 entry methods. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…zero Hide All (or hiding the one entry method carrying the traffic) left the paint scale with no positive maximum, and GrayPaintScale throws on an empty range. Clamp the maximum to one so the chart comes out uniformly white instead. Found by Kale on the 896-PE frontier trace. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lvkale
requested review from
ericjbohm,
matthiasdiener and
ritvikrao
as code owners
August 23, 2026 03:42
ritvikrao
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Kale's wishlist, verified by him in the GUI on the 896-PE frontier trace: study message sizes one entry method (or a few) at a time.
The reader was already handed each message's entry method and threw it away. Counts are now kept per entry method (
[timeBin][msgBin][ep], about 2 MB at the default 100x10 bins for 500 entry methods), and only the chosen ones are summed into the chart, so toggling re-aggregates in memory with no log re-read. The heat colors renormalize to the visible subset, which is what makes focusing on one entry method's sizes readable.A Select Entry Methods button (with an "N of M shown" label) opens the shared
ChooseEntriesWindowwith its visibility column; the window implementsEntryMethodVisibilitywithsortEntriesByCount, so entry methods are listed busiest first with their message counts. Everything starts visible, so the chart is unchanged until something is switched off.Details:
GrayPaintScalerejects an empty range).🤖 Generated with Claude Code